开源改变世界

Homing error in code #18

推推 grbl 2年前 (2023-01-21) 227次浏览

 Closed

Homing error in code#18

byenilmez opened this issue on Mar 29, 2011 · 6 comments

Comments

Homing error in code #18

Hi,
I was just testing the code but had troubles using homing function. I think there is a typo error in: https://github.com/simen/grbl/blob/edge/limits.c.
In line 59,63 and 67 “LIMIT_PIN” should be replaced with “limit_bits”. Or it will never execute the switch release code.
i.e.
if (x_axis && !(LIMIT_PIN & (1<<X_LIMIT_BIT))) {
should be changed to:
if (x_axis && !(limit_bits & (1<<X_LIMIT_BIT))) {
.

Anyway thanks for the great project, take care.

Bekir

Homing error in code #18
Member
simen commented on Apr 9, 2011

Thanks! The limit code is experimental as I have no limit switches to test
with. Made as a template for another team to flesh out. If you feel the
urge, please contribute fixes or advice in as detailed manner as you are
able!

I’m sorry for the radio silence. We suddenly found our dream home and
promptly bought it. Grbl dev is on hiatus until june, I’ll fix it then!
http://is.gd/5JImZJ

On Mon, Mar 28, 2011 at 10:02 PM, byenilmez <
reply@reply.github.com>wrote:

Hi,
I was just testing the code but had troubles using homing function. I think
there is a typo error in: https://github.com/simen/grbl/blob/edge/limits.c
.
In line 59,63 and 67 “LIMIT_PIN” should be replaced with “limit_bits”. Or
it will never execute the switch release code.
i.e.
if (x_axis && !(LIMIT_PIN & (1

Reply to this email directly or view it on GitHub:
https://github.com/simen/grbl/issues/18

Homing error in code #18
Author

Hi,
*
*
Congratulations on your new home. Hope you have a long and healthy life
there.

*
*
I have changed the code as a mentioned. then tweaked pause length to meet
the speed of my motors and now it works fine. Thanks again for this project.
*
*
*
*Take care,

*
*
*Bekir
*
On Fri, Apr 8, 2011 at 9:47 PM, simen <
reply@reply.github.com>wrote:

Thanks! The limit code is experimental as I have no limit switches to test
with. Made as a template for another team to flesh out. If you feel the
urge, please contribute fixes or advice in as detailed manner as you are
able!

I’m sorry for the radio silence. We suddenly found our dream home and
promptly bought it. Grbl dev is on hiatus until june, I’ll fix it then!
http://is.gd/5JImZJ

On Mon, Mar 28, 2011 at 10:02 PM, byenilmez <
reply@reply.github.com>wrote:

Hi,
I was just testing the code but had troubles using homing function. I
think
there is a typo error in:
https://github.com/simen/grbl/blob/edge/limits.c
.
In line 59,63 and 67 “LIMIT_PIN” should be replaced with “limit_bits”. Or
it will never execute the switch release code.
i.e.
if (x_axis && !(LIMIT_PIN & (1

Reply to this email directly or view it on GitHub:
https://github.com/simen/grbl/issues/18

Reply to this email directly or view it on GitHub:
https://github.com/simen/grbl/issues/18#comment_975116

Homing error in code #18

Hi,
where I can find:
https://github.com/simen/grbl/blob/edge/limits.c
Maybe I have no rights to acess this directoy??

regards
Michael

Homing error in code #18
ril3y commented on Apr 9, 2011

Switch branches to the “edge” branch. Checkout that branch..
git checkout branch should work.

Hope that helps….
ril3y

Homing error in code #18

“edge” was it…..
thank you!

Michael

Homing error in code #18
Member
simen commented on Jun 6, 2011

I’ll be closing this issue as this is not really a bug, and is worked on by the Lasersaur people. I will backport their solution when it is solid.

Homing error in code #18 simen closed this as completed on Jun 6, 2011
喜欢 (0)